On Mon, May 28, 2018 at 11:55 AM, Maciej Purski m.purski@samsung.com wrote:
The patch adds bridge and panel nodes. It adds also DSI properties specific for arndale board.
Signed-off-by: Andrzej Hajda a.hajda@samsung.com Signed-off-by: Maciej Purski m.purski@samsung.com
arch/arm/boot/dts/exynos5250-arndale.dts | 39 ++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts index 80221fa..6f0b1c4 100644 --- a/arch/arm/boot/dts/exynos5250-arndale.dts +++ b/arch/arm/boot/dts/exynos5250-arndale.dts @@ -71,6 +71,17 @@ }; };
panel: panel {compatible = "boe,hv070wsa-100";power-supply = <&vcc_3v3_reg>;enable-gpios = <&gpd1 3 GPIO_ACTIVE_HIGH>;port {panel_ep: endpoint {remote-endpoint = <&bridge_out_ep>;};};};regulators { compatible = "simple-bus"; #address-cells = <1>;@@ -476,6 +487,34 @@ }; };
+&dsi_0 {
Please put the node alphabetically, so before &dp.
Also this patch should be squashed with previous one (regulators), because adding non-controllable fixed regulators on its own does not bring benefits. Linux will not disable them. You added these regulators for the bridge below. Without the bridge, their existence does not have much sense.
Best regards, Krzysztof
vddcore-supply = <&ldo8_reg>;vddio-supply = <&ldo10_reg>;samsung,pll-clock-frequency = <24000000>;samsung,burst-clock-frequency = <320000000>;samsung,esc-clock-frequency = <10000000>;status = "okay";bridge@0 {reg = <0>;compatible = "toshiba,tc358764";vddc-supply = <&vcc_1v2_reg>;vddio-supply = <&vcc_1v8_reg>;vddmipi-supply = <&vcc_1v2_reg>;vddlvds133-supply = <&vcc_3v3_reg>;vddlvds112-supply = <&vcc_1v2_reg>;reset-gpios = <&gpd1 6 GPIO_ACTIVE_LOW>;#address-cells = <1>;#size-cells = <0>;port@1 {reg = <1>;bridge_out_ep: endpoint {remote-endpoint = <&panel_ep>;};};};+};
&i2c_2 { status = "okay"; /* used by HDMI DDC */ -- 2.7.4