On 24/05/18 11:57, Neil Armstrong wrote:
The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device when the CEC feature bit is present.
Signed-off-by: Neil Armstrong narmstrong@baylibre.com Reviewed-by: Enric Balletbo i Serra enric.balletbo@collabora.com
For whatever it is worth:
Acked-by: Hans Verkuil hans.verkuil@cisco.com
Regards,
Hans
drivers/mfd/cros_ec_dev.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index 1d6dc5c..272969e 100644 --- a/drivers/mfd/cros_ec_dev.c +++ b/drivers/mfd/cros_ec_dev.c @@ -383,6 +383,10 @@ static void cros_ec_sensors_register(struct cros_ec_dev *ec) kfree(msg); }
+static const struct mfd_cell cros_ec_cec_cells[] = {
- { .name = "cros-ec-cec" }
+};
static const struct mfd_cell cros_ec_rtc_cells[] = { { .name = "cros-ec-rtc" } }; @@ -426,6 +430,18 @@ static int ec_device_probe(struct platform_device *pdev) if (cros_ec_check_features(ec, EC_FEATURE_MOTION_SENSE)) cros_ec_sensors_register(ec);
- /* Check whether this EC instance has CEC host command support */
- if (cros_ec_check_features(ec, EC_FEATURE_CEC)) {
retval = mfd_add_devices(ec->dev, PLATFORM_DEVID_AUTO,cros_ec_cec_cells,ARRAY_SIZE(cros_ec_cec_cells),NULL, 0, NULL);if (retval)dev_err(ec->dev,"failed to add cros-ec-cec device: %d\n",retval);- }
- /* Check whether this EC instance has RTC host command support */ if (cros_ec_check_features(ec, EC_FEATURE_RTC)) { retval = mfd_add_devices(ec->dev, PLATFORM_DEVID_AUTO,