On Tue, Dec 07, 2021 at 01:33:59PM +0100, Christian König wrote:
Drivers should never touch this directly.
Signed-off-by: Christian König christian.koenig@amd.com
drivers/dma-buf/dma-resv.c | 17 +++++++++++++++++ include/linux/dma-resv.h | 17 ----------------- 2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c index 694716a3d66d..9acceabc9399 100644 --- a/drivers/dma-buf/dma-resv.c +++ b/drivers/dma-buf/dma-resv.c @@ -147,6 +147,23 @@ void dma_resv_fini(struct dma_resv *obj) } EXPORT_SYMBOL(dma_resv_fini);
+/**
- dma_resv_excl_fence - return the object's exclusive fence
- @obj: the reservation object
- Returns the exclusive fence (if any). Caller must either hold the objects
- through dma_resv_lock() or the RCU read side lock through rcu_read_lock(),
- or one of the variants of each
- RETURNS
- The exclusive fence or NULL
- */
Same thing with us not documenting internals, pls drop the comment outright it doesn't really explain anything. With that:
Reviewed-by: Daniel Vetter daniel.vetter@ffwll.ch
+static inline struct dma_fence * +dma_resv_excl_fence(struct dma_resv *obj) +{
- return rcu_dereference_check(obj->fence_excl, dma_resv_held(obj));
+}
/**
- dma_resv_shared_list - get the reservation object's shared fence list
- @obj: the reservation object
diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h index cdfbbda6f600..40ac9d486f8f 100644 --- a/include/linux/dma-resv.h +++ b/include/linux/dma-resv.h @@ -412,23 +412,6 @@ static inline void dma_resv_unlock(struct dma_resv *obj) ww_mutex_unlock(&obj->lock); }
-/**
- dma_resv_excl_fence - return the object's exclusive fence
- @obj: the reservation object
- Returns the exclusive fence (if any). Caller must either hold the objects
- through dma_resv_lock() or the RCU read side lock through rcu_read_lock(),
- or one of the variants of each
- RETURNS
- The exclusive fence or NULL
- */
-static inline struct dma_fence * -dma_resv_excl_fence(struct dma_resv *obj) -{
- return rcu_dereference_check(obj->fence_excl, dma_resv_held(obj));
-}
void dma_resv_init(struct dma_resv *obj); void dma_resv_fini(struct dma_resv *obj); int dma_resv_reserve_shared(struct dma_resv *obj, unsigned int num_fences); -- 2.25.1