On Tue, Mar 22, 2022 at 05:16:43PM +0800, Chen-Yu Tsai wrote:
On Tue, Mar 22, 2022 at 4:52 PM Xin Ji xji@analogixsemi.com wrote:
On Tue, Mar 22, 2022 at 04:43:20PM +0800, Hsin-Yi Wang wrote:
On Tue, Mar 22, 2022 at 4:02 PM Xin Ji xji@analogixsemi.com wrote:
As downstream sink was set into standby mode while bridge disabled, this patch used for setting downstream sink into normal status while enable bridge.
Signed-off-by: Xin Ji xji@analogixsemi.com Reviewed-by: Pin-Yen Lin treapking@chromium.org
V1 -> V2: use dev_dbg replace of dev_info
drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 9a2a19ad4202..dcf3275a00fe 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -924,12 +924,20 @@ static void anx7625_dp_start(struct anx7625_data *ctx) { int ret; struct device *dev = &ctx->client->dev;
u8 data; if (!ctx->display_timing_valid) { DRM_DEV_ERROR(dev, "mipi not set display timing yet.\n"); return; }dev_dbg(dev, "set downstream sink into normal\n");/* Downstream sink enter into normal mode */data = 1;ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data);if (ret < 0)dev_err(dev, "IO error : set sink into normal mode fail\n");The driver uses DRM_DEV_* for logs. Can we use this?
Hi Hsin-Yi, as comment in drm/drm_print.h: "NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not use DRM_DEV_* any more. I'll send a patch to replace all of DRM_DEV_* later.
drm_dbg is better than dev_dbg though. With the former, you still get the option to control it with the drm.debug module parameter, unlike the latter which normally gets compiled out.
Please use drm_dbg*.
ChenYu
Hi ChenYu, the parameter of drm_dbg is "drm", if use drm_dbg, it will change more code, I'll consider to upstream new patch to replace all of them later.
Thanks, Xin
Thanks, Xin
/* Disable HDCP */ anx7625_write_and(ctx, ctx->i2c.rx_p1_client, 0xee, 0x9f);-- 2.25.1