Hi,
On Sat, Aug 28, 2021 at 7:40 AM Bjorn Andersson bjorn.andersson@linaro.org wrote:
On Fri 27 Aug 15:52 CDT 2021, Doug Anderson wrote:
Hi,
On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson bjorn.andersson@linaro.org wrote:
+static int dp_parser_find_panel(struct dp_parser *parser) +{
struct device_node *np = parser->pdev->dev.of_node;int rc;rc = drm_of_find_panel_or_bridge(np, 2, 0, &parser->drm_panel, NULL);Why port 2? Shouldn't this just be port 1 always? The yaml says that port 1 is "Output endpoint of the controller". We should just use port 1 here, right?
I thought port 1 was the link to the Type-C controller, didn't give it a second thought and took the next available.
But per the binding it makes sense that the panel is the "Output endpoint of the controller" and I guess one will have either a Type-C controller or a panel - even after the DP rework?
Right, my understanding is that "port 1" is the output port irregardless of whether you're outputting to a panel or a DP connector. I think the only case it would make sense to add a new port is if it was possible for the output to be connected to both a panel and a DP port simultaneously. ...but that doesn't make sense.
-Doug