There is no real reason to require drivers to set and use dev->dev_private. Indeed, the current recommendation, as documented in drm_device.h, is to embed struct drm_device in the per-device struct instead of using dev_private.
Remove the requirement for dev_private to have been set to indicate driver initialization.
Cc: Chris Wilson chris@chris-wilson.co.uk Cc: Daniel Vetter daniel@ffwll.ch Signed-off-by: Jani Nikula jani.nikula@intel.com
---
Any ideas for something else drm_irq_install() could/should check to ensure "Driver must have been initialized"?
There are only a few instances of dev_private uses in i915, also to be removed, and we could stop initializing dev_private altogether. We could in fact do that without this patch too, as we don't use drm_irq_install(). But it would be cleaner to not have any checks for driver private stuff outside of drivers. --- drivers/gpu/drm/drm_irq.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index 03bce566a8c3..588be45abd7a 100644 --- a/drivers/gpu/drm/drm_irq.c +++ b/drivers/gpu/drm/drm_irq.c @@ -111,10 +111,6 @@ int drm_irq_install(struct drm_device *dev, int irq) if (irq == 0) return -EINVAL;
- /* Driver must have been initialized */ - if (!dev->dev_private) - return -EINVAL; - if (dev->irq_enabled) return -EBUSY; dev->irq_enabled = true;