Hi Vinod,
On Wed, 2021-03-17 at 15:52 +0530, Vinod Koul wrote:
On 08-03-21, 11:52, Liu Ying wrote:
This patch allows LVDS PHYs to be configured through the generic functions and through a custom structure added to the generic union.
The parameters added here are based on common LVDS PHY implementation practices. The set of parameters should cover all potential users.
Cc: Kishon Vijay Abraham I kishon@ti.com Cc: Vinod Koul vkoul@kernel.org Cc: NXP Linux Team linux-imx@nxp.com Reviewed-by: Robert Foss robert.foss@linaro.org Signed-off-by: Liu Ying victor.liu@nxp.com
v3->v4:
- Add Robert's R-b tag.
v2->v3:
- No change.
v1->v2:
- No change.
include/linux/phy/phy-lvds.h | 48 ++++++++++++++++++++++++++++++++++++++++++++ include/linux/phy/phy.h | 4 ++++ 2 files changed, 52 insertions(+) create mode 100644 include/linux/phy/phy-lvds.h
diff --git a/include/linux/phy/phy-lvds.h b/include/linux/phy/phy-lvds.h new file mode 100644 index 00000000..1b5b9d6 --- /dev/null +++ b/include/linux/phy/phy-lvds.h @@ -0,0 +1,48 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/*
- Copyright 2020 NXP
- */
+#ifndef __PHY_LVDS_H_ +#define __PHY_LVDS_H_
+/**
- struct phy_configure_opts_lvds - LVDS configuration set
- This structure is used to represent the configuration state of a
- LVDS phy.
- */
+struct phy_configure_opts_lvds {
- /**
* @bits_per_lane_and_dclk_cycle:** Number of bits per data lane and differential clock cycle.*/Can we have these in kernel-doc style please, similar to style in linux/phy/phy.h
I take this way of in-line member documentation comment for the below 3 reasons:
1) Members of struct phy_configure_opts_mipi_dphy and struct phy_configure_opts_dp use the same way of comment. The structures are defined in linux/phy/phy-mipi-dphy.h and linux/phy/phy-dp.h respectively. Aligning to them makes a bit sense, IMHO.
2) In-line member documentation comments[1] are mentioned in kernel-doc guide. It says 'The structure members may also be documented in-line within the definition.'.
3) Even the 'configure' and 'validate' members of struct phy_ops use the same way of comment. struct phy_ops is defined in linux/phy/phy.h.
[1] https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html#in-line-mem...
Regards, Liu Ying
- unsigned int bits_per_lane_and_dclk_cycle;
- /**
* @differential_clk_rate:** Clock rate, in Hertz, of the LVDS differential clock.*/- unsigned long differential_clk_rate;
- /**
* @lanes:** Number of active, consecutive, data lanes, starting from* lane 0, used for the transmissions.*/- unsigned int lanes;
- /**
* @is_slave:** Boolean, true if the phy is a slave which works together* with a master phy to support dual link transmission,* otherwise a regular phy or a master phy.*/- bool is_slave;
+};
+#endif /* __PHY_LVDS_H_ */ diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h index e435bdb..d450b44 100644 --- a/include/linux/phy/phy.h +++ b/include/linux/phy/phy.h @@ -17,6 +17,7 @@ #include <linux/regulator/consumer.h>
#include <linux/phy/phy-dp.h> +#include <linux/phy/phy-lvds.h> #include <linux/phy/phy-mipi-dphy.h>
struct phy; @@ -51,10 +52,13 @@ enum phy_mode {
the MIPI_DPHY phy mode.- @dp: Configuration set applicable for phys supporting
the DisplayPort protocol.
- @lvds: Configuration set applicable for phys supporting
*/
the LVDS phy mode.union phy_configure_opts { struct phy_configure_opts_mipi_dphy mipi_dphy; struct phy_configure_opts_dp dp;
- struct phy_configure_opts_lvds lvds;
};
/**
2.7.4