Am Freitag, den 17.07.2020, 12:45 +0300 schrieb Laurentiu Palcu:
Hi Lukas and Daniel,
On Fri, Jul 17, 2020 at 11:27:58AM +0200, Daniel Vetter wrote:
On Fri, Jul 17, 2020 at 11:12:39AM +0200, Lucas Stach wrote:
Am Freitag, den 17.07.2020, 10:59 +0200 schrieb Daniel Vetter:
On Fri, Jul 17, 2020 at 10:18 AM Lucas Stach l.stach@pengutronix.de wrote:
Hi Laurentiu,
Am Donnerstag, den 09.07.2020, 19:47 +0300 schrieb Laurentiu Palcu:
From: Laurentiu Palcu laurentiu.palcu@nxp.com
Hi,
This patchset adds initial DCSS support for iMX8MQ chip. Initial support includes only graphics plane support (no video planes), no HDR10 capabilities, no graphics decompression (only linear, tiled and super-tiled buffers allowed).
Support for the rest of the features will be added incrementally, in subsequent patches.
The patchset was tested with both HDP driver (in the downstream tree) and the upstream MIPI-DSI driver (with a couple of patches on top, to make it work correctly with DCSS).
I think the series (minus 3/5 and minor correction to the DT binding) is fine to go in now. So just some formal questions: are you going to maintain this driver in upstream? If so we should add a MAINTAINERS entry to that effect. I can offer to act as a reviewer in this case.
I can maintain the DCSS driver, sure, and the more reviewers the better. Thanks for helping out with this. Should I send a v6 then with a patch for MAINTAINERS?
How do you intend to merge this? IMO pushing this through drm-misc seems like the right thing to do. If you agree I can help you get this applied. If you are going to maintain the driver on your own, I think you should then apply for commit rights to drm-misc.
drm/imx isn't listed yet as under the drm-misc umbrella, maybe we should put the entire collective of imx drivers under drm-misc? Or maybe it's just an oversight that the git repo isn't specified in the MAINTAINERS entry. Also maybe we should add the pengutronix kernel team alias there too?
drm/imx was exclusively the IPUv3 up until now, which is in fact maintained outside of drm-misc in its own git tree. This has worked quite well in the past so even though IPUv3 doesn't see a lot of churn these days the motivation to change anything to this workflow is quite low. And yes, the git tree is missing from the MAINTAINERS entry.
For the DCSS driver, if it's going to be maintained by NXP, I figured it might be easier for Laurentiu to push things into drm-misc than set up a separate public git tree. But IMHO that's fully up to him to decide.
/me puts on maintainer hat
Much prefer drm-misc over random people playing maintainer and fumbling it. I think the reasonable options are either in the current imx tree, or drm-misc. Standalone tree for these small drivers just doesn't make much sense.
I don't have anything against either method, though I have to agree I like things to be simple. Going through drm-misc sounds simple enough to me. :) However, since there is going to be more activity in the DRM IMX area in the future, reviving the drm/imx tree, and push all IMX related stuff through drm/imx, could make sense as well.
I think drm-misc is the right place then.
Please send a v6 with the following changes: - drop the component framework patch - drop the i.MX8MQ DT patch, this should go through Shawn's imx tree after the driver and binding has landed in drm-misc - you can add my Reviewed-by to the whole series or I can add it when applying - add a MAINTAINERS entry, please add me as a reviewer if you don't mind
I can push this initial series into drm-misc until you've got your own commit rights.
Regards, Lucas