Hi Laurentiu,
Thank you for the patch.
On Mon, Jul 20, 2020 at 03:42:27PM +0300, Laurentiu Palcu wrote:
From: Laurentiu Palcu laurentiu.palcu@nxp.com
After the drm_bridge_connector_init() helper function has been added, the ADV driver has been changed accordingly. However, the 'type' field of the bridge structure was left unset, which makes the helper function always return -EINVAL.
Signed-off-by: Laurentiu Palcu laurentiu.palcu@nxp.com
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
Hi,
I've hit this while trying to use this helper in the new i.MX8MQ DCSS driver, as suggested by Sam, and I wanted to test it with NWL MIPI_DSI and ADV since support is already in mainline.
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index f45cdca9cce5..a0d392c338da 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -1283,6 +1283,7 @@ static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id) adv7511->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID | DRM_BRIDGE_OP_HPD; adv7511->bridge.of_node = dev->of_node;
adv7511->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
drm_bridge_add(&adv7511->bridge);