Re: [PATCH v3 3/4] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

Hi Alexander,

Thank you for the patch.

On Tue, Oct 19, 2021 at 08:52:38AM +0200, Alexander Stein wrote:

Add a VCC regulator which needs to be enabled before the EN pin is released.

Reviewed-by: Sam Ravnborg sam@ravnborg.org Signed-off-by: Alexander Stein alexander.stein@ew.tq-group.com

---

.../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 4 ++++ 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml index a5779bf17849..f1e4f149ccb4 100644 --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml @@ -32,6 +32,9 @@ properties: maxItems: 1 description: GPIO specifier for bridge_en pin (active high).

• vcc-supply:
• description: A 1.8V power supply (see regulator/regulator.yaml).

I would have dropped the part between parentheses as it's kind of implied, but I don't mind much.

Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com

• ports: $ref: /schemas/graph.yaml#/properties/ports

@@ -134,6 +137,7 @@ examples: reg = <0x2d>;

         enable-gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>;

•        vcc-supply = <&reg_sn65dsi83_1v8>;
  
         ports {
             #address-cells = <1>;