Integer variable 'identical' is being initialized however this value is never read as 'identical' is assigned the result of 'start + (width - end)'. Remove the redundant assignment. At the same time, adjust the declarations order of variables to keep the "upside-down x-mas tree" look of them.
Clean up clang warning:
drivers/video/fbdev/udlfb.c:370:6: warning: Value stored to 'identical' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
Reported-by: Abaci Robot abaci@linux.alibaba.com Signed-off-by: Yang Li yang.lee@linux.alibaba.com --- drivers/video/fbdev/udlfb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c index b9cdd02..f40dd6d8 100644 --- a/drivers/video/fbdev/udlfb.c +++ b/drivers/video/fbdev/udlfb.c @@ -363,13 +363,13 @@ static int dlfb_ops_mmap(struct fb_info *info, struct vm_area_struct *vma) */ static int dlfb_trim_hline(const u8 *bback, const u8 **bfront, int *width_bytes) { - int j, k; - const unsigned long *back = (const unsigned long *) bback; const unsigned long *front = (const unsigned long *) *bfront; + const unsigned long *back = (const unsigned long *) bback; const int width = *width_bytes / sizeof(unsigned long); - int identical = width; int start = width; int end = width; + int identical; + int j, k;
for (j = 0; j < width; j++) { if (back[j] != front[j]) {