On Wed, Sep 18, 2019 at 2:49 PM Eric Engestrom eric@engestrom.ch wrote:
On Tuesday, 2019-09-17 19:15:36 +0000, John Stultz wrote:
This patch removes the deprecated Android.mk files and replaces them with Android.bp files.
This is needed in order to build libdrm/master against recent Android releases and AOSP/master, as some of the Treble build options required since Android O cannot be expressed in Andorid.mk files.
Patch originally by Dan Willemsen with fixes folded in by: Jerry Zhang, Eliott Hughes and myself.
With this change, the only patches carried by Android for libdrm would be the gerrit OWNERS meta-data file.
Cc: Mauro Rossi issor.oruam@gmail.com Cc: Chih-Wei Huang cwhuang@android-x86.org Cc: Robert Foss robert.foss@collabora.com Cc: Tapani Pälli tapani.palli@intel.com Cc: Chih-Wei Huang cwhuang@android-x86.org Cc: Emil Velikov emil.velikov@collabora.com Cc: Sean Paul seanpaul@chromium.org Cc: Rob Clark robdclark@chromium.org Cc: Eric Anholt anholt@google.com Cc: Jiyong Park jiyong@google.com Cc: Alistair Strachan astrachan@google.com Cc: Dan Willemsen dwillemsen@google.com Cc: Sumit Semwal sumit.semwal@linaro.org Cc: Vishal Bhoj vishal.bhoj@linaro.org Signed-off-by: John Stultz john.stultz@linaro.org
I know last time this was proposed, there was some concern about maintaining support for old AOSP releases - and while we could still support both with Android.mk that was a fair concern.
However, now that it is a requirement for newer releases, I'd contend that being able to build/test libdrm/master against AOSP/master and recent releases is more valuable then soley maintaining support for old and unsupported Android releases.
Acked-by: Eric Engestrom eric@engestrom.ch
But to be clear, what's the earliest android version that supports blueprint? (might be worth adding that to the commit message)
I believe it was Android N which was the first to use blueprint.
Thanks for the review, I'll add such a note to the commit and resubmit w/o RFC in a few days.
thanks -john