Dear Takashi,
Thank you for posting these patches for review.
Am Dienstag, den 18.07.2017, 16:43 +0200 schrieb Takashi Iwai:
From: Egbert Eich eich@suse.de
The depth/bpp handling for chips with limited memory in commit 918be888d613 ("drm/mgag200: on cards with < 2MB VRAM default to 16-bit") was incomplete: the bpp limits were applied to mode validation.
This consolidates dpeth/bpp handling, adds it to mode validation
depth
and moves the code which reads the command line specified depth into the correct location.
Fixes: 918be888d613 ("drm/mgag200: on cards with < 2MB VRAM default to 16-bit")
``` $ git tag --contains 918be888d613 | head -1 v3.14 ```
Please mark this as stable then too?
Also, could the original commit author time-stamps be preserved if you have them in your SUSE repositories? The `Date` line could be added below the `From` line. That would help to know for how long the changes have been tested.
Signed-off-by: Egbert Eich eich@suse.de Signed-off-by: Takashi Iwai tiwai@suse.de
drivers/gpu/drm/mgag200/mgag200_drv.h | 2 ++ drivers/gpu/drm/mgag200/mgag200_fb.c | 7 +------ drivers/gpu/drm/mgag200/mgag200_main.c | 9 ++++++--- drivers/gpu/drm/mgag200/mgag200_mode.c | 14 +++++++------- 4 files changed, 16 insertions(+), 16 deletions(-)
[…]
Otherwise this looks fine.
Thanks,
Paul