Re: [PATCH 02/10] drm: Rename plane atomic_check state names

Hi,

On Fri, Jan 15, 2021 at 02:46:36PM +0100, Thomas Zimmermann wrote:

Hi

Am 15.01.21 um 13:56 schrieb Maxime Ripard:

...

diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index 8a4235d9d9f1..2cb09e9d9306 100644 --- a/drivers/gpu/drm/imx/ipuv3-plane.c +++ b/drivers/gpu/drm/imx/ipuv3-plane.c @@ -344,12 +344,12 @@ static const struct drm_plane_funcs ipu_plane_funcs = { }; static int ipu_plane_atomic_check(struct drm_plane *plane,

• 		  struct drm_plane_state *state)
  

• 		  struct drm_plane_state *new_state)
  

It's not 'new_plane_state' ?

That function is using old_state for plane->state:

...

{ struct drm_plane_state *old_state = plane->state;

Here ^

So it felt more natural to keep the convention in use in that driver

Maxime