On Fri, Aug 29, 2014 at 12:12:39PM +0200, David Herrmann wrote:
The sigdata structure is only used to group two fields in drm_device. Inline it and make it an unnamed object.
I'm not sure what unnamed object means.
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
[...]
@@ -1035,9 +1029,13 @@ struct drm_device {
struct drm_sg_mem *sg; /**< Scatter gather memory */ unsigned int num_crtcs; /**< Number of CRTCs on this device */
- struct drm_sigdata sigdata; /**< For block_all_signals */ sigset_t sigmask;
- struct {
int context;
Your patch doesn't introduce this, but shouldn't context here be unsigned given that it's compared to drm_hw_lock's .lock field?
I guess struct drm_lock could have that same change. I suppose it might not be all that important since presumably the code works, but it's still inconsistent use of types.
Anyway, if you could clarify the "unnamed object" in the commit description, this patch:
Reviewed-by: Thierry Reding treding@nvidia.com