On Fri, Dec 04, 2015 at 09:45:45AM +0100, Daniel Vetter wrote:
Originally the idea behind void* was to allow different sets of helpers. But now we have that (with probe, plane, crtc and atomic helpers) and we still just use the same set of vtables. That's the only way to make the individual helpers modular and allow drivers to pick&choose and transition between them. So this flexibility isn't really needed. Also we have lots of non-vtable data meanwhile in core structures too, this is not the first one at all.
Given that the void * is only trouble since gcc can't warn you if you mix them up. Let's fix that and make them typesafe.
Signed-off-by: Daniel Vetter daniel.vetter@intel.com
include/drm/drm_crtc.h | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
Very good:
Reviewed-by: Thierry Reding treding@nvidia.com