8 Sep
2019
8 Sep
'19
4:04 p.m.
Hi Dan.
On Wed, Sep 04, 2019 at 09:55:07PM +0300, Dan Carpenter wrote:
The "lvds->backlight" pointer could be NULL in situations were of_parse_phandle() returns NULL. Also it's slightly cleaner to use backlight_put() which already has a check for NULL built in.
Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver") Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
A much better fix would be to introduce use of devm_of_find_backlight(). Then you do not have to worry about put().
Care to respin a v3 that does this?
Sam