Hi,
On Wed, May 11, 2022 at 3:58 PM Douglas Anderson dianders@chromium.org wrote:
The drm_helper_probe_single_connector_modes() is a bit long. Let's break a chunk off to update and validate modes. This helps avoid one goto and also will allow us to more easily call the helper a second time in a future patch without adding looping or another goto.
This change is intended to be a no-op change--just code movement.
Signed-off-by: Douglas Anderson dianders@chromium.org Reviewed-by: Abhinav Kumar quic_abhinavk@quicinc.com Reviewed-by: Thomas Zimmermann tzimmermann@suse.de
Changes in v3:
- Removed WARN_ON
Changes in v2:
- Two underscores for __drm_helper_update_and_validate().
- Return err and use WARN_ON instead of returning a bool.
drivers/gpu/drm/drm_probe_helper.c | 106 ++++++++++++++++------------- 1 file changed, 60 insertions(+), 46 deletions(-)
Pushed to drm-misc-next:
4a2a13a57b60 drm/probe-helper: Add helper for drm_helper_probe_single_connector_modes()