> 1. add the new dpm asic callbacks
> 2. add the common hwmon fan code.  Make sure it's only enabled on asics
> which support manual fan control
> 3. wire up the CI specific code

Ok, makes sense

> 
> As far as percent vs. rpm, I'm not sure which would be preferred.  I think
> the hwmon subsystem generally prefers rpm.  Maybe add callbacks for both
> percent and rpm and then check rdev->pm.fan_pulses_per_revolution.  If it's
> 0, expose it as a percent.  if not, expose as rpm.  Thoughts?  Might be
> worth asking on the hwmon mailing lists.

Good idea, I'll try to test rpm behaviour today

> Also, we should only expose these on asics which support fan control.

No problem, some tinkering with `hwmon_attributes_visible` should make it.

I'll refresh & update patches on weekend.