On Sat, Apr 20, 2013 at 01:28:53PM +0200, Daniel Vetter wrote:
On Sat, Apr 20, 2013 at 12:11 PM, Chris Wilson chris@chris-wilson.co.uk wrote:
On Sat, Apr 20, 2013 at 12:08:11PM +0200, Daniel Vetter wrote:
In
commit 9e8944ab564f2e3dde90a518cd32048c58918608 Author: Chris Wilson chris@chris-wilson.co.uk Date: Thu Nov 15 11:32:17 2012 +0000
drm: Introduce an iterator over holes in the drm_mm range managerhelpers and iterators for hole handling have been introduced with some debug BUG_ONs sprinkled over. Unfortunately this broke the mm dumper which unconditionally tried to compute the size of the very first hole.
[snip]
Use __drm_mm_hole_node_start and __drm_mm_hole_node_end instead.
I've figured I could make the condition more symmetric with the one in the loop, so that both check ->hole_follows.
Your change log didn't explain your intentions to refactor the code, only to avoid the extra BUG_ON... -Chris