On 21/10/02 05:30AM, Ville Syrjälä wrote:
On Sat, Oct 02, 2021 at 01:05:47AM +0300, Ville Syrjälä wrote:
On Fri, Oct 01, 2021 at 04:48:15PM -0400, Sean Paul wrote:
On Fri, Oct 01, 2021 at 10:00:50PM +0300, Ville Syrjälä wrote:
On Fri, Oct 01, 2021 at 02:36:55PM -0400, Sean Paul wrote:
Thank you for revising, Fernando! I've pushed the set to drm-misc-next (along with the necessary drm-tip conflict resolutions).
Ugh. Did anyone actually review the locking changes this does? I shot the previous i915 stuff down because the commit messages did not address any of it.
I reviewed the set on 9/17, I didn't see your feedback on that thread.
It was much earlir than that. https://lists.freedesktop.org/archives/dri-devel/2021-June/313193.html
And I think I might have also shot down a similar thing earlier.
I was actually half considering sending a patch to nuke that misleading TODO item. I don't think anything which changes which locks are taken should be considred a starter level task. And the commit messages here don't seem to address any of it.
And i915 is now broken :(
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10680/fi-bwr-2160/boot.html
I completely overlooked the side effects of not having a global context anymore. Sorry for all the trouble.
Sean, could you revert the whole patch series? I'll have a deeper look into the patch set and come up with a v3 where all these issues will be addressed.
Thanks and sorry once again for the extra overhead this might have caused.