Re: [PATCH v2 01/10] drm/i915: Merge of visible and !visible paths for primary planes

On Mon, Sep 22, 2014 at 07:23:08PM -0300, Gustavo Padovan wrote:

From: Gustavo Padovan gustavo.padovan@collabora.co.uk

Fold intel_pipe_set_base() in the update primary plane path merging pieces of code that are common to both paths.

Basically the the pin/unpin procedures are the same for both paths and some checks can also be shared (some of the were moved to the check() stage)

Woah! Have you fixed the current regressions introduced by the earlier patches?

xrandr <output> --rotate inverted is broken as the set-property calls plane restore without the plane ever being configured, even though the CRTC is active.

A sketchy and completely broken patch: http://patchwork.freedesktop.org/patch/33855/ -Chris