Hi Sam,
On Fri, 10 Jun 2022 22:22:59 +0200, Sam Ravnborg sam@ravnborg.org wrote:
On Tue, Jun 07, 2022 at 08:55:16PM +0200, Stephen Kitt wrote:
backlight_properties.fb_blank is deprecated. The states it represents are handled by other properties; but instead of accessing those properties directly, drivers should use the helpers provided by backlight.h.
Instead of manually checking the power state in struct backlight_properties, use backlight_is_blank().
Signed-off-by: Stephen Kitt steve@sk2.org Cc: Greg Kroah-Hartman gregkh@linuxfoundation.org Cc: "Noralf Trønnes" noralf@tronnes.org Cc: Thomas Zimmermann tzimmermann@suse.de Cc: Andy Shevchenko andriy.shevchenko@linux.intel.com Cc: Javier Martinez Canillas javierm@redhat.com Cc: Len Baker len.baker@gmx.com Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Cc: linux-staging@lists.linux.dev
drivers/staging/fbtft/fb_ssd1351.c | 3 +-- drivers/staging/fbtft/fbtft-core.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/staging/fbtft/fb_ssd1351.c index 6fd549a424d5..b8d55aa8c5c7 100644 --- a/drivers/staging/fbtft/fb_ssd1351.c +++ b/drivers/staging/fbtft/fb_ssd1351.c @@ -196,8 +196,7 @@ static int update_onboard_backlight(struct backlight_device *bd) "%s: power=%d, fb_blank=%d\n", __func__, bd->props.power, bd->props.fb_blank);
Could you try to kill this use of props.fb_blank too? ^^^^^^ A local variable should do the trick.
I have a pending patch changing this to show props.state instead, that way the debug info shows all the backlight-relevant information from props. How does that sound?
Regards,
Stephen