Hi Daniel,
On Fri, Feb 20, 2015 at 3:42 PM, Beeresh Gopal gbeeresh@codeaurora.org wrote:
+/* Samsung framebuffer modifiers */
+/*
- NV12 64x32 Tiled
- 2 planes Y and CbCr, grouped into 64x32 macro tiles,
- with a non-standard order in memory (Z-shape).
- Pixel layout identical to DRM_FORMAT_NV21 format:
- index 0 = Y plane, [7:0] Y
- index 1 = Cb:Cr plane, [15:0] Cb:Cr little endian
- */
+#define DRM_FORMAT_MOD_SAMSUNG_64_32_TILE fourcc_mod_code(SAMSUNG, 1)
This description mixes layout information with pixel format. Strictly speaking you could use this for other formats, but since the description doesn't mention whether this is in bytes or pixels that's a bit awkward. Or just mandatae that this can only be used with NV12 fourcc (and maybe add a check for that into the core drm code.
Agreed: I think /* Tiled: 64x32 pixel macroblocks */ - or something along those lines - as a description should do the trick.
Also, is this really samsung and not mpeg?
From my understanding the VENDOR is actually SAMSUNG for the following
reasons: a) V4L2_PIX_FMT_NV12MT has been introduced[1] for the Samsungs s5p-fimc driver (which got renamed into exynos4-is[2]) b) A search on V4L2_PIX_FMT_NV12MT in the drivers folder only returns Samsung drivers so far..
[1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4a... [2] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=56...
-Daniel
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Stéphane