On Mon, Oct 09, 2017 at 05:24:29PM +0100, Chris Wilson wrote:
Quoting Ville Syrjälä (2017-10-09 17:18:17)
On Mon, Sep 25, 2017 at 08:19:12PM +0100, Chris Wilson wrote:
Quoting ville.syrjala@linux.intel.com (2016-04-01 19:48:50)
From: Ville Syrjälä ville.syrjala@linux.intel.com
Eliminate the duplicate code for pipe timing readout in intel_crtc_mode_get() by using the functions we use for the normal state readout.
v2: Store dotclock in adjusted_mode instead of the final mode
Cc: dri-devel@lists.freedesktop.org Cc: Rob Kramer rob@solution-space.com Cc: Daniel Vetter daniel.vetter@ffwll.ch Signed-off-by: Ville Syrjälä ville.syrjala@linux.intel.com
Reviewed-by: Chris Wilson chris@chris-wilson.co.uk
Thanks for the review. Patches pushed to dinq.
Fixes a pipe-state warn for me, Tested-by: Chris Wilson chris@chris-wilson.co.uk
However, now that I look at the code again I'm not 100% sure why this fixed anything. The readout still seems to fail at fully populating the mode flags. I'll post a more thorough solution that simply calls the normal state readout hooks for the crtc and encoder...
The first patch fixed up the implied A,B transcoder mixup. I just tested both patches together. Do you want me to double check if it was just the first patch that silenced the warnings? I'm just happy to have a clean boot!
I think the first patch should have been a nop for you since 845g only has the one pipe.