On Thu, Oct 03, 2019 at 12:38:43PM +0530, Jagan Teki wrote:
On Tue, Oct 1, 2019 at 1:33 PM Icenowy Zheng icenowy@aosc.io wrote:
This reverts commit da676c6aa6413d59ab0a80c97bbc273025e640b2.
The original commit adds a start parameter to the calculation of the start delay according to some old BSP versions from Allwinner. However, there're two ways to add this delay -- add it in DSI controller or add it in the TCON. Add it in both controllers won't work.
The code before this commit is picked from new versions of BSP kernel, which has a comment for the 1 that says "put start_delay to tcon". By checking the sun4i_tcon0_mode_set_cpu() in sun4i_tcon driver, it has already added this delay, so we shouldn't repeat to add the delay in DSI controller, otherwise the timing won't match.
Thanks for this change. look like this is proper reason for adding +
- also adding bsp code links here might help for future reference.
Otherwise,
Reviewed-by: Jagan Teki jagan@amarulasolutions.com
The commit log was better in this one. I ended up merging this one, with your R-b.
Maxime