Am 11.06.2015 10:49, schrieb Dan Carpenter:
debugfs_create_file() can return an error pointer if debugfs is disabled or it can return NULL on error.
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 36be03c..adba2a1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -1980,6 +1980,8 @@ static int amdgpu_debugfs_regs_init(struct amdgpu_device *adev) adev, &amdgpu_debugfs_regs_fops); if (IS_ERR(ent)) return PTR_ERR(ent);
- if (!ent)
return -ENOMEM;
would PTR_ERR_OR_ZERO() by an option ?
on the other hand, why does debugfs_create_file() does not return -ENOMEN instead of NULL ?
re, wh
-- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html