Re: [RESEND][PATCH v8 1/5] dma-buf: Add dma-buf heaps framework

On Sun, Sep 29, 2019 at 8:27 PM Hillf Danton hdanton@sina.com wrote:

On Fri, 6 Sep 2019 18:47:08 +0000 John Stultz wrote:

...

+/**

• • dma_heap_get_data() - get per-heap driver data
• • @heap: DMA-Heap to retrieve private data for
• • Returns:
• • The per-heap data for the heap.
• */

+void *dma_heap_get_data(struct dma_heap *heap);

It will help readers more than thought understand this framework if s/get_data/get_drvdata/

Sounds good!

Thanks for the review and suggestion! -john