On Thu, Nov 18, 2021 at 10:26:29AM +0100, Heiko Stübner wrote:
Hi Kever,
Am Donnerstag, 18. November 2021, 02:27:10 CET schrieb Kever Yang:
Hi Sascha Hauer,
On 2021/11/17 下午10:33, Sascha Hauer wrote:
This series adds initial graphics support for the Rockchip RK356[68] SoCs. Graphics support is based around the VOP2 controller which replaces the VOP controller found on earlier Rockchip SoCs. The driver has been tested with HDMI support included in this series and MIPI-DSI which is not included because it needs some more work. The driver is taken from the downstream Rockchip kernel
Yes, you do know this is from Rockchip kernel.
Could you point me out where is the information about original author in your commit?
The copyrights for added files seem to have stayed intact. For example the added rockchip_drm_vop2.c file in patch12 does contain the copyright as
Copyright (c) 2020 Rockchip Electronics Co., Ltd. Author: Andy Yan andy.yan@rock-chips.com
We can of course debate if the commit-author should also be set to Andy or another Rockchip engineer, with Sascha adding a "Co-developed-by" with his credentials.
That's probably a nice compromise, I guess.
The commit author was merely lost while copying the driver file into my git. Changing it back to Andy is fine with me, I didn't mean to steal anyones credits.
Sascha