On Wed, 20 May 2015, Arnd Bergmann arnd@arndb.de wrote:
This function was added recently but never used, and causes a compile warning:
drivers/gpu/drm/drm_crtc.c:4324:13: warning: 'drm_property_unreference_blob_locked' defined but not used [-Wunused-function]
Removing that function avoids the warning. It can simply be put back in case it is needed in the future.
http://mid.gmane.org/CAPj87rMPtafeYNzgXoP+fx0dAqhwaD7kdnJgqb_vdbPtiOrXPg@mai...
Signed-off-by: Arnd Bergmann arnd@arndb.de Fixes: 6bcacf51d05 ("drm: Add reference counting to blob properties")
The broken patch is currently in git://anongit.freedesktop.org/drm-intel#topic/drm-misc
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 4059f065c854..6e60f71bbf46 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -4313,25 +4313,6 @@ void drm_property_unreference_blob(struct drm_property_blob *blob) EXPORT_SYMBOL(drm_property_unreference_blob);
/**
- drm_property_unreference_blob_locked - Unreference a blob property with blob_lock held
- Drop a reference on a blob property. May free the object. This must be
- called with blob_lock held.
- @param dev Device the blob was created on
- @param blob Pointer to blob property
- */
-static void drm_property_unreference_blob_locked(struct drm_property_blob *blob) -{
- if (!blob)
return;- DRM_DEBUG("%p: blob ID: %d (%d)\n", blob, blob->base.id, atomic_read(&blob->refcount.refcount));
- kref_put(&blob->refcount, drm_property_free_blob);
-}
-/**
- drm_property_reference_blob - Take a reference on an existing property
- Take a new reference on an existing blob property.
dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel