On Thu, Jul 15, 2021 at 4:25 AM Doug Anderson dianders@chromium.org wrote:
- Alter the logic so that we assign the backlight handle to panel->backlight directly and save some code.
Officially this is disallowed according to comments. ...and I quote:
/**
- @backlight:
- Backlight device, used to turn on backlight after the call
- to enable(), and to turn off backlight before the call to
- disable().
- backlight is set by drm_panel_of_backlight() or
- drm_panel_dp_aux_backlight() and drivers shall not assign it.
*/
I do not personally know the motivation of not letting drivers assign it, but with the words "shall not". Yikes!
I think it's a documentation bug. I trust Sam more than the docs. I'll send a patch.
Yours, Linus Walleij