On Thu, Jun 03, 2021 at 11:41:01PM +0200, Daniel Vetter wrote:
On Thu, Jun 3, 2021 at 11:29 PM Kees Cook keescook@chromium.org wrote:
On Thu, Jun 03, 2021 at 02:19:52PM -0700, Kees Cook wrote:
On Thu, Jun 03, 2021 at 09:19:42PM +0200, Daniel Vetter wrote:
On Thu, Jun 3, 2021 at 8:43 PM Rob Herring robh@kernel.org wrote:
On Wed, Jun 2, 2021 at 4:53 PM Kees Cook keescook@chromium.org wrote:
Avoid randconfig build failures by requiring VEXPRESS_CONFIG:
aarch64-linux-gnu-ld: drivers/gpu/drm/pl111/pl111_versatile.o: in function `pl111_vexpress_clcd_init': pl111_versatile.c:(.text+0x220): undefined reference to `devm_regmap_init_vexpress_config'
pl111_vexpress_clcd_init() starts with:
if (!IS_ENABLED(CONFIG_VEXPRESS_CONFIG)) return -ENODEV;
Isn't that supposed to be enough to avoid an undefined reference?
Ah! I missed that when reading the code. I see the problem now. It's because of:
CONFIG_VEXPRESS_CONFIG=m CONFIG_DRM_PL111=y
I think the right fix is:
diff --git a/drivers/gpu/drm/pl111/Kconfig b/drivers/gpu/drm/pl111/Kconfig index 80f6748055e3..662fc38f92ba 100644 --- a/drivers/gpu/drm/pl111/Kconfig +++ b/drivers/gpu/drm/pl111/Kconfig @@ -3,6 +3,7 @@ config DRM_PL111 tristate "DRM Support for PL111 CLCD Controller" depends on DRM depends on ARM || ARM64 || COMPILE_TEST
depends on VEXPRESS_CONFIG=y || VEXPRESS_CONFIG=DRMOops, no, I had this backwairds:
depends on !VEXPRESS_CONFIG || VEXPRESS_CONFIG=DRMCan you pls throw this into an incremental patch on top of drm-misc-next? It's a non-rebasing tree and all that (linux-next should have it next day too I guess).
Ah! Yes, sorry. I wasn't sure if you'd reverted it yet. One moment...
-Kees