On Tue, Jul 21, 2015 at 03:51:40PM +0200, Daniel Vetter wrote:
On Tue, Jul 21, 2015 at 05:36:45PM +0530, Sudip Mukherjee wrote:
While creating the debugfs file we are setting the inode->i_private to dev. That same dev is passed to these functions as private of struct seq_file via single_open(). Moreover single_open is setting file->private_data->private to dev. So at this point it can never be NULL. This check was added by commit eb3394faeb97 ("drm/i915: Add debugfs test control files for Displayport compliance testing")
Still missing
Cc: Chris Wilson ... Cc: Todd Previte ...
here to make sure reviewers/original authors are in the loop. Anyway this is a simple enough patch, so I just pulled them both in.
Sorry. did you mean to put Cc: here before the Signed-off-by: ? I have put them in Cc list of the patches. For my next patch you will not get these issues.
regards sudip