Re: [PATCH] drm/atmel-hlcdc: Fix suspend/resume implementation

Hi,

On Wed, Mar 01, 2017 at 01:31:01PM +0100, Boris Brezillon wrote:

The current suspend resume implementation is assuming register values are kept when entering suspend, which is no longer the case with the suspend-to-RAM on the sama5d2.

While at it, switch to the generic infrastructure to enter suspend mode (drm_atomic_helper_suspend/resume()).

Signed-off-by: Boris Brezillon boris.brezillon@free-electrons.com

No regression on sama5d3, atmel_hlcdc_crtc_disable/enable are still called at suspend/resume and pinctrl_pm_select_sleep_state which is just for my unusual screen (no display pin, so I need to clamp all pads) is still called, thus it works for me.

Tested-by: Sylvain Rochet sylvain.rochet@finsecur.com

Cheers, Sylvain