On Wed, Aug 11, 2021 at 12:51:56PM -0600, Rob Herring wrote:
On Wed, Aug 04, 2021 at 04:13:51PM +0800, Shawn Guo wrote:
The Truly NT35521 is a 5.24" 1280x720 DSI panel, and the backlight is managed through DSI link.
Signed-off-by: Shawn Guo shawn.guo@linaro.org
.../bindings/display/panel/truly,nt35521.yaml | 62 +++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml b/Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml new file mode 100644 index 000000000000..4727c3df6eb8 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/truly,nt35521.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Truly NT35521 5.24" 1280x720 MIPI-DSI Panel
+maintainers:
- Shawn Guo shawn.guo@linaro.org
+description: |
- The Truly NT35521 is a 5.24" 1280x720 MIPI-DSI panel. The panel backlight
- is managed through DSI link.
+allOf:
- $ref: panel-common.yaml#
+properties:
- compatible:
- const: truly,nt35521
- reg: true
- reset-gpios: true
- enable-gpios: true
- pwr-positive5-gpios:
- maxItems: 1
- pwr-negative5-gpios:
- maxItems: 1
Are these +/-5V supplies? If so, they should be modeled with gpio-regulator perhaps unless the panel connection could only ever be GPIOs.
Hi Rob,
The binding has been updated in v2 [1]. Please help review that. Thanks!
Shawn
[1] https://lore.kernel.org/linux-arm-msm/20210809051008.6172-2-shawn.guo@linaro...
+required:
- compatible
- reg
- reset-gpios
- enable-gpios
- pwr-positive5-gpios
- pwr-negative5-gpios
+additionalProperties: false
+examples:
- |
- #include <dt-bindings/gpio/gpio.h>
- dsi {
#address-cells = <1>;#size-cells = <0>;panel@0 {compatible = "truly,nt35521";reg = <0>;reset-gpios = <&msmgpio 25 GPIO_ACTIVE_LOW>;pwr-positive5-gpios = <&msmgpio 114 GPIO_ACTIVE_HIGH>;pwr-negative5-gpios = <&msmgpio 17 GPIO_ACTIVE_HIGH>;enable-gpios = <&msmgpio 10 GPIO_ACTIVE_HIGH>;};- };
+...
2.17.1