(In reply to Mike Lothian from comment #16)
> It helps the original issue where a saw a panic / stack trace on shutdown
> and shutdown took a while - so that's great news
> 
> I've retested compiling amdgpu as a module and modprobe -r(ing) it - this
> still kills my machine, would you be interested in me taking more
> diagnostics? Or can that now be considered a separate bug?

Separate bug.  With this patch, the two code paths (module unload and shutdown
are now separate).