Re: [Intel-gfx] [PATCH 1/4] drm: Support legacy cursor ioctls via universal planes when possible (v2)

On Sat, May 17, 2014 at 12:43:04AM +0200, Daniel Vetter wrote:

On Sat, May 17, 2014 at 12:38 AM, Matt Roper matthew.d.roper@intel.com wrote:

...

•   if (ret) {
  

•           if (req->flags & DRM_MODE_CURSOR_BO)
  

•                   drm_mode_rmfb(dev, &fb->base.id, file_priv);
  

•           return ret;
  

•   }
  

With the new refcount logic an unconditional drm_framebuffer_unreference should be here instead of this. I think, but please double-check since it's late here ;-) -Daniel

Actually, I'm not sure if we want the unreference at all. setplane_internal() unrefs fb on failure (and old_fb on success), so I think that's already taken care of.

Matt