Re: [PATCH v5 2/2] fbcon: Silence fbcon logo on 'quiet' boots

On Apr 02 2019, Prarit Bhargava prarit@redhat.com wrote:

On 4/1/19 3:31 PM, Andreas Schwab wrote:

...

On Jan 29 2019, Prarit Bhargava prarit@redhat.com wrote:

...

@@ -1066,6 +1069,9 @@ static void fbcon_init(struct vc_data *vc, int init)

cap = info->flags;

• if (console_loglevel <= CONSOLE_LOGLEVEL_QUIET)

• logo_shown = FBCON_LOGO_DONTSHOW;
  

• if (vc != svc || logo_shown == FBCON_LOGO_DONTSHOW || (info->fix.type == FB_TYPE_TEXT)) logo = 0;

This causes the scroll region to no longer be reset when the logo is removed.

Andreas, my apologies but I'm not sure what you mean. Could you elaborate on the broken and expected behaviour?

If fbcon_init is called after the loglevel is reduced to CONSOLE_LOGLEVEL_QUIET, the logo is not drawn, but the scrolling region remains.

Andreas.