Hi myself and others.
On Thu, May 14, 2020 at 09:09:49PM +0200, Sam Ravnborg wrote:
There are no external users of of_find_backlight_by_node(). Make it static so we keep it that way.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Lee Jones lee.jones@linaro.org Cc: Daniel Thompson daniel.thompson@linaro.org Cc: Jingoo Han jingoohan1@gmail.com
drivers/video/backlight/backlight.c | 22 +++++++++------------- include/linux/backlight.h | 10 ---------- 2 files changed, 9 insertions(+), 23 deletions(-)
diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c index 547aa3e1a03a..91dfcf4a2087 100644 --- a/drivers/video/backlight/backlight.c +++ b/drivers/video/backlight/backlight.c @@ -577,19 +577,9 @@ static int of_parent_match(struct device *dev, const void *data) return dev->parent && dev->parent->of_node == data; }
-/**
- of_find_backlight_by_node() - find backlight device by device-tree node
- @node: device-tree node of the backlight device
- Returns a pointer to the backlight device corresponding to the given DT
- node or NULL if no such backlight device exists or if the device hasn't
- been probed yet.
- This function obtains a reference on the backlight device and it is the
- caller's responsibility to drop the reference by calling put_device() on
- the backlight device's .dev field.
- */
-struct backlight_device *of_find_backlight_by_node(struct device_node *node) +/* Find backlight device by device-tree node */ +static struct backlight_device * +of_find_backlight_by_node(struct device_node *node) { struct device *dev;
@@ -598,6 +588,12 @@ struct backlight_device *of_find_backlight_by_node(struct device_node *node) return dev ? to_backlight_device(dev) : NULL; } EXPORT_SYMBOL(of_find_backlight_by_node);
Dropped this EXPORT in v2.
Sam
+#else +static struct backlight_device * +of_find_backlight_by_node(struct device_node *node) +{
- return NULL;
+} #endif
static struct backlight_device *of_find_backlight(struct device *dev) diff --git a/include/linux/backlight.h b/include/linux/backlight.h index 3d757a850b88..b7839ea9d00a 100644 --- a/include/linux/backlight.h +++ b/include/linux/backlight.h @@ -198,16 +198,6 @@ struct generic_bl_info { void (*kick_battery)(void); };
-#ifdef CONFIG_OF -struct backlight_device *of_find_backlight_by_node(struct device_node *node); -#else -static inline struct backlight_device * -of_find_backlight_by_node(struct device_node *node) -{
- return NULL;
-} -#endif
#if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) struct backlight_device *devm_of_find_backlight(struct device *dev);
#else
2.25.1