From: Colin Ian King colin.king@canonical.com
The call to drm_dp_aux_init never returns an error code and there is no error return being assigned to variable ret. The check for an error in ret is always false since ret is still zero from the start of the function so the init error check and error message is redundant and can be removed.
Addresses-Coverity: ("Logically dead code") Fixes: fd43ad9d47e7 ("drm/nouveau/kms/nv50-: Move AUX adapter reg to connector late register/early unregister") Signed-off-by: Colin Ian King colin.king@canonical.com --- drivers/gpu/drm/nouveau/nouveau_connector.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c index 22b83a6577eb..f37e5f28a93f 100644 --- a/drivers/gpu/drm/nouveau/nouveau_connector.c +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c @@ -1362,12 +1362,6 @@ nouveau_connector_create(struct drm_device *dev, dcbe->hasht, dcbe->hashm); nv_connector->aux.name = kstrdup(aux_name, GFP_KERNEL); drm_dp_aux_init(&nv_connector->aux); - if (ret) { - NV_ERROR(drm, "Failed to init AUX adapter for sor-%04x-%04x: %d\n", - dcbe->hasht, dcbe->hashm, ret); - kfree(nv_connector); - return ERR_PTR(ret); - } fallthrough; default: funcs = &nouveau_connector_funcs;