Re: [PATCH v5] drm/msm/dp: stop event kernel thread when DP unbind

Quoting Kuogee Hsieh (2022-04-14 14:51:19)

diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 01453db..baba95d 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -230,6 +231,18 @@ void dp_display_signal_audio_complete(struct msm_dp *dp_display) complete_all(&dp->audio_comp); }

One too many newlines

+static void dp_hpd_event_thread_stop(struct dp_display_private *dp_priv) +{

•   kthread_stop(dp_priv->ev_tsk);
  

•   /* reset event q to empty */
  

•   dp_priv->event_gndx = 0;
  

•   dp_priv->event_pndx = 0;
  

+}

This can move after the start function?

+static int dp_hpd_event_thread_start(struct dp_display_private *dp_priv);

static int dp_display_bind(struct device *dev, struct device *master, void *data) {

Otherwise

Reviewed-by: Stephen Boyd swboyd@chromium.org