Hi Javier,
I love your patch! Yet something to improve:
[auto build test ERROR on drm/drm-next] [also build test ERROR on shawnguo/for-next linus/master linux/master v5.18-rc5 next-20220502] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Javier-Martinez-Canillas/drm-... base: git://anongit.freedesktop.org/drm/drm drm-next config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220503/202205030810.VwAEOAqj-lkp@i...) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/28ef46724e385165777a21d9f66118... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Javier-Martinez-Canillas/drm-Allow-simpledrm-to-setup-its-emulated-FB-as-firmware-provided/20220502-234145 git checkout 28ef46724e385165777a21d9f661188fa2577a1e # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All errors (new ones prefixed by >>):
drivers/gpu/drm/tiny/simpledrm.c: In function 'simpledrm_probe':
drivers/gpu/drm/tiny/simpledrm.c:904:38: error: implicit declaration of function 'DRM_FB_SET_OPTION'; did you mean 'DRM_FB_GET_OPTION'? [-Werror=implicit-function-declaration]
904 | drm_fbdev_generic_setup(dev, DRM_FB_SET_OPTION(DRM_FB_FW, 1)); | ^~~~~~~~~~~~~~~~~ | DRM_FB_GET_OPTION
drivers/gpu/drm/tiny/simpledrm.c:904:56: error: 'DRM_FB_FW' undeclared (first use in this function)
904 | drm_fbdev_generic_setup(dev, DRM_FB_SET_OPTION(DRM_FB_FW, 1)); | ^~~~~~~~~ drivers/gpu/drm/tiny/simpledrm.c:904:56: note: each undeclared identifier is reported only once for each function it appears in cc1: some warnings being treated as errors
vim +904 drivers/gpu/drm/tiny/simpledrm.c
884 885 /* 886 * Platform driver 887 */ 888 889 static int simpledrm_probe(struct platform_device *pdev) 890 { 891 struct simpledrm_device *sdev; 892 struct drm_device *dev; 893 int ret; 894 895 sdev = simpledrm_device_create(&simpledrm_driver, pdev); 896 if (IS_ERR(sdev)) 897 return PTR_ERR(sdev); 898 dev = &sdev->dev; 899 900 ret = drm_dev_register(dev, 0); 901 if (ret) 902 return ret; 903
904 drm_fbdev_generic_setup(dev, DRM_FB_SET_OPTION(DRM_FB_FW, 1));
905 906 return 0; 907 } 908