On Thu, Nov 21, 2019 at 04:42:10PM +0000, Ruhl, Michael J wrote:
-----Original Message----- From: Intel-gfx intel-gfx-bounces@lists.freedesktop.org On Behalf Of Gerd Hoffmann Sent: Thursday, November 21, 2019 5:38 AM To: dri-devel@lists.freedesktop.org Cc: David Airlie airlied@linux.ie; intel-gfx@lists.freedesktop.org; open list linux-kernel@vger.kernel.org; Maxime Ripard mripard@kernel.org; Gerd Hoffmann kraxel@redhat.com Subject: [Intel-gfx] [PATCH 2/2] drm: share address space for dma bufs
Use the shared address space of the drm device (see drm_open() in drm_file.c) for dma-bufs too. That removes a difference betweem drm device mmap vmas and dma-buf mmap vmas and fixes corner cases like unmaps not working properly.
Hi Gerd,
Just want to make sure I understand this...
So unmaps will not work correctly for mappings when a driver does a drm_vma_node_unamp()?
Completely removing the mapping (aka munmap syscall) works fine. Zapping the pte's (using madvise(dontneed) for example) doesn't.
This is a day one bug?
I guess so, but I'll leave that to others being active longer than me in drm hacking to answer ...
cheers, Gerd