Le mer. 27 nov. 2019 à 17:19, Sam Ravnborg sam@ravnborg.org a écrit :
Hi Mihail.
I can see from grepping that bridge.driver_private is used in a couple of other files in sti/
Like sti_hdmi.c: bridge->driver_private = hdmi; bridge->funcs = &sti_hdmi_bridge_funcs; drm_bridge_attach(encoder, bridge, NULL);
I wonder if a drm_bridge_init() should be added there. I did not look closely - but it looked suspisiously.
My goal with drm_bridge_init() was to get devlinks sorted out for cross-module uses of a drm_bridge (via of_drm_find_bridge()), so I only considered locations where drm_bridge_add/remove() were used.
Would you be okay with a promise to push a cleanup of this one and the one in sti_hda.c after patch 1/30 lands in some form? I'd rather not make this series much longer, it's already pushing it at 30 :).
Absolutely - my drive-by comment was more out of concern if this was missing. A clean-up later souns good.
Or you can just do the changes for sti_hdmi and sti_hda in this patch too.
Benjamin
Sam
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel