Re: [PATCH v5 6/7] drm/mediatek: support CMDQ interface in ddp component

On Tue, Dec 10, 2019 at 5:05 AM Bibby Hsieh bibby.hsieh@mediatek.com wrote:

+void mtk_ddp_write(struct cmdq_pkt *cmdq_pkt, unsigned int value,

•              struct mtk_ddp_comp *comp, unsigned int offset)
  

+{ +#if IS_ENABLED(CONFIG_MTK_CMDQ)

Should we use #ifdef like in v4? https://patchwork.kernel.org/patch/11274439/

We got warnings while compiling kernels if CONFIG_MTK_CMDQ is not set, since cmdq_pkt_write() would still be compiled. Similar in other #if IS_ENABLED(CONFIG_MTK_CMDQ) (also in 7/7 https://patchwork.kernel.org/patch/11281349/)

•   if (cmdq_pkt)
  

•           cmdq_pkt_write(cmdq_pkt, comp->subsys,
  

•                          comp->regs_pa + offset, value);
  

•   else
  

+#endif

•           writel(value, comp->regs + offset);
  

+}