Re: [Intel-gfx] [PATCH] drm: Protect drm_connector_register_all() under DRIVER_MODESET

On Sat, Jun 18, 2016 at 02:26:36PM +0100, Emil Velikov wrote:

Hi Chris,

On 18 June 2016 at 13:13, Chris Wilson chris@chris-wilson.co.uk wrote:

...

•   drm_connector_register_all(dev);
  

•   if (drm_core_check_feature(dev, DRIVER_MODESET))
  

•           drm_connector_register_all(dev);
  
  

Shouldn't the drm_connector_unregister_all() call in drm_dev_unregister() be guarded by a similar check ?

Yes, kbuild doesn't unload the module.... Better add that to my test as well. -Chris