Am Sa., 5. Juni 2021 um 14:24 Uhr schrieb Bernard Zhao bernard@vivo.com:
NULL check before kvfree functions is not needed.
Signed-off-by: Bernard Zhao bernard@vivo.com
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c index d05c35994579..bd0d66ebf314 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c @@ -612,14 +612,10 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data, err_submit_cmds: if (ret && (out_fence_fd >= 0)) put_unused_fd(out_fence_fd);
if (stream)kvfree(stream);if (bos)kvfree(bos);if (relocs)kvfree(relocs);if (pmrs)kvfree(pmrs);
kvfree(stream);kvfree(bos);kvfree(relocs);kvfree(pmrs); return ret;}
2.31.0
Thanks for the patch, but there is an other one queued up in etnaviv/next that fixes the same issue: https://git.pengutronix.de/cgit/lst/linux/commit/?h=etnaviv/next&id=bdf6...