On 05/19/2017 07:24 AM, Oscar Salvador wrote:
This v8 fixes removes dummy functions which only had a return and moves the code into the switch statements.
Merged. Thank you!
Versions:
v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild complains. v4 -> v5: * Drops a check for attr_set in "nouveau_temp_is_visible". v5 -> v6: * Change to nouveau/hwmon all commit titles * Drop author change * Coding-Style * Move the check before the switch in nouveau_power_is_visible function * Expose temperature attrs as RW again * Get rid of nouveau_hwmon_set_pwm1/_enable and implement the code inside nouveau_pwm_write * Get rid of nouveau_hwmon_set_temp_* and implement the code inside nouveau_temp_write v6 -> v7: * Got rid of all dummy functions that only had a return, and moved code into the switch statements. v7 -> v8:
- Fix warnings
This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup.
Oscar Salvador (5): nouveau/hwmon: Add config for all sensors and their settings nouveau/hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string nouveau/hwmon: Remove old code, add .write/.read operations nouveau/hwmon: expose the auto_point and pwm_min/max attrs nouveau/hwmon: Change permissions to numeric
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 983 +++++++++++++++----------------- 1 file changed, 464 insertions(+), 519 deletions(-)