Re: [PATCH v8 12/13] drm/mediatek: add MERGE support for mediatek-drm

Hi, Jason:

On Thu, 2021-08-19 at 10:23 +0800, jason-jh.lin wrote:

Add MERGE engine file: MERGE module is used to merge two slice-per-line inputs into one side-by-side output.

Signed-off-by: jason-jh.lin jason-jh.lin@mediatek.com

[snip]

+int mtk_merge_clk_enable(struct device *dev) +{

• int ret = 0;
• struct mtk_disp_merge *priv = dev_get_drvdata(dev);
• ret = clk_prepare_enable(priv->clk);
• if (ret)

• pr_err("merge clk prepare enable failed\n");
  

• if (priv->async_clk) {

This checking is redundant.

• ret = clk_prepare_enable(priv->async_clk);
  

• if (ret)
  

• 	pr_err("async clk prepare enable failed\n");
  

• }
• return ret;

+}

+void mtk_merge_clk_disable(struct device *dev) +{

• struct mtk_disp_merge *priv = dev_get_drvdata(dev);
• if (priv->async_clk)

Ditto.

Regards, CK

• clk_disable_unprepare(priv->async_clk);
  

• clk_disable_unprepare(priv->clk);

+}