I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu chuansheng.liu@intel.com Signed-off-by: Baole Ni baolex.ni@intel.com --- drivers/gpu/drm/qxl/qxl_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c index dc9df5f..f62a099 100644 --- a/drivers/gpu/drm/qxl/qxl_drv.c +++ b/drivers/gpu/drm/qxl/qxl_drv.c @@ -51,10 +51,10 @@ static int qxl_modeset = -1; int qxl_num_crtc = 4;
MODULE_PARM_DESC(modeset, "Disable/Enable modesetting"); -module_param_named(modeset, qxl_modeset, int, 0400); +module_param_named(modeset, qxl_modeset, int, S_IRUSR);
MODULE_PARM_DESC(num_heads, "Number of virtual crtcs to expose (default 4)"); -module_param_named(num_heads, qxl_num_crtc, int, 0400); +module_param_named(num_heads, qxl_num_crtc, int, S_IRUSR);
static struct drm_driver qxl_driver; static struct pci_driver qxl_pci_driver;